Add search this user/agent to ProfilePage - #98091

Hey, I noticed you changed src/languages/en.ts in a PR from a fork. For security reasons, translations are not generated automatically for PRs from forks.

If you want to automatically generate translations for other locales, an Expensify employee will have to:

1. Look at the code and make sure there are no malicious changes.
2. Run the Generate static translations GitHub workflow. If you have write access and the K2 extension, you can simply click: [this button]

Alternatively, if you are an external contributor, you can run the translation script locally with your own OpenAI API key. To learn more, try running:

npx ts-node ./scripts/generateTranslations.ts --help

Typically, you'd want to translate only what you changed by running npx ts-node ./scripts/generateTranslations.ts --compare-ref main

@marufsharifi Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

Reviewer Checklist

• I have verified the author checklist is complete (all boxes are checked off).
• I verified the correct issue is linked in the ### Fixed Issues section above
• I verified testing steps are clear and they cover the changes made in this PR
  • I verified the steps for local testing are in the Tests section
  • I verified the steps for Staging and/or Production testing are in the QA steps section
  • I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
  • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
• I checked that screenshots or videos are included for tests on all platforms
• I included screenshots or videos for tests on all platforms
• I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
• I verified tests pass on all platforms & I tested again on:
  • Android: HybridApp
  • Android: mWeb Chrome
  • iOS: HybridApp
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
• If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
• I verified proper code patterns were followed (see Reviewing the code)
  • I verified that comments were added to code that is not self explanatory
  • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
  • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
• If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
• I verified that this PR follows the guidelines as stated in the Review Guidelines
• I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
• If a new component is created I verified that:
  • A similar component doesn't exist in the codebase
  • All props are defined accurately
  • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
  • The only data being stored in the state is data necessary for rendering and nothing else
  • The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
• If a new CSS style is added I verified that:
  • A similar style doesn't already exist
  • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
• If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
• If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
• If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
• If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
• If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
  • I verified that all the inputs inside a form are aligned with each other.
  • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
• For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
• If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
• I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

@hungvu193, could you please check the failure actions, when you get a chance. thanks.

Fixed 😄. Btw, I'm asking for confirmation in Slack, so can you please hold the review for a while?

Codecov Report

✅ Changes either increased or maintained existing code coverage, great job!

@marufsharifi it's now ready

I am testing it. thanks.

@MelvinBot Review

Review — LGTM ✅

The change is clean, minimal, and matches the "Chat with agent" pattern requested in the issue. I verified the feature end-to-end on web and it works as intended.

What I checked

• The new MenuItem in ProfilePage.tsx:316-329 builds the query with type: chat + from: [accountID] and navigates to SEARCH_ROOT.
• from is a supported filter for the chat data type (SearchAdvancedFiltersForm.ts:627-631), so buildQueryStringFromFilterFormValues won't strip it.
• Visibility guard !!accountID && !isAnonymousUserSession() correctly hides the item for accountID === 0 (DEFAULT_NUMBER_ID) and anonymous sessions.
• Label switches via isAgentEmail(login); login defaulting to '' is handled safely.
• MagnifyingGlass is a valid Expensicon and correctly added to useMemoizedLazyExpensifyIcons.
• Translations added for all 11 locales.
• Only failing checks are checklist / Check independent approval (reviewer-checklist gates), not code checks. Tests, typecheck, lint, React Compiler all pass.

Live test (web): opened a profile → "Search this user" appears with the magnifying-glass icon → clicking it navigated to search?q=type:chat from:8392101, correctly pre-filtering to that user's chats.

Two things worth confirming before approving:

1. Shown on your own profile too. The guard doesn't exclude isCurrentUser, so "Search this user" also appears on your own profile (searching your own chats). The issue says "add it to every profile … valuable for any user," so this is likely intended — just confirm it's desired rather than accidental.
2. No unit test in the diff, although the author checklist has "I added unit tests" checked. For a trivial menu item this is often acceptable, but the checkbox/diff mismatch is worth reconciling.

I couldn't exercise the "Search this agent" label live (no *@expensify.ai agent chat in the test account), but the branch logic at ProfilePage.tsx:319 is correct — worth a manual check against a real agent profile (e.g. RuleBot) during QA.

Address all your comments. It's now ready for your another review @marufsharifi

@Expensify/design what do you all think of this? I'm not really sold. "Search this user" feels super ambiguous to me.

Yeah, that wording feels odd and I agree we should do something else. "View agent history" or "View completed actions" feels better, something like that.

Also, I wanted to confirm that we always show this MenuItem in the same stack as the Copilot row? I see in some videos above they were separated:

Agree with your placement suggestion. And I think I like View agent history because this is essentially just a search returning all messages from the agent / user. So they might not all be actions.

Agree with Shawn and Danny. Both placement and wording feels better with their suggestions.

Also, I wanted to confirm that we always show this MenuItem in the same stack as the Copilot row? I see in some videos above they were separated:

It's right below the copilot menu item. I forgot to update the screenshots after discussing on Slack, let me update it

just to confirm, with agent we will show: View agent history and with user we will show View user history right?

Oh I didn't realize we were doing this for regular users too but I guess that makes sense.

I also kind of think the "Notify me" setting would be above the MenuItems. Basically the block of MenuItems would be the very last thing in that RHP:

I see. I'll update it shortly. Thanks for confirmation 🙏

Updated

I think that looks good 👍

checking again. thanks.

@hungvu193, could you please check this. thanks.

Hey, I noticed you changed src/languages/en.ts in a PR from a fork. For security reasons, translations are not generated automatically for PRs from forks.

If you want to automatically generate translations for other locales, an Expensify employee will have to:

1. Look at the code and make sure there are no malicious changes.
2. Run the Generate static translations GitHub workflow. If you have write access and the K2 extension, you can simply click: [this button]

Alternatively, if you are an external contributor, you can run the translation script locally with your own OpenAI API key. To learn more, try running:

npx bun ./scripts/generateTranslations.ts --help

Typically, you'd want to translate only what you changed by running npx bun ./scripts/generateTranslations.ts --compare-ref main

Fixed. Can you verify again?

@hungvu193, could you please check this. thanks.

@marufsharifi Fixed your review again. Can you rereview it? Ty